[ClimateHydro] Apply Climate Adjustment Factors to Hydropower CF in Input Processing#129
Draft
jvcarag wants to merge 3 commits into
Draft
[ClimateHydro] Apply Climate Adjustment Factors to Hydropower CF in Input Processing#129jvcarag wants to merge 3 commits into
jvcarag wants to merge 3 commits into
Conversation
- Add procedure for applying climate adjustments in hydcf.py - Modify climateprep.py to output hydadjsea.csv as climate_hydadjsea.csv in long format (deletes temp_hydadjsea.csv) - Remove procedures for temp_hydadjsea.csv from hourly_writetimeseries.py - Remove instances of climate_hydadjsea.csv and climate_hydro_* parameters from b_inputs.gms and 2_temporal_params.gms - Add entries for hydadjann.csv and hydadjsea.csv back into runfiles.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the procedure for applying climate adjustment factors to hydropower capacity factors (CF) up to the
hydcf.pyinput processing script instead of doing so in2_temporal_params.gms.Technical details
Climate adjustment factors are not being read in or applied to stress-period-indexed hydropower CF data, causing certain non-dispatchable hydro techs to have CFs of
0for these timeslices (details are outlined in Issue #116).Additionally, hydropower CF data used by PRAS do not include these climate adjustments, because the adjustments are not applied to the hydropower CF file ingested by the resource adequacy tool (details outlined in Issue #131).
To resolve both issues, this PR applies the climate adjustment factors to hydropower CFs when the latter are first being processed in
reeds/input_processing/hydcf.py- this works because the adjustment factors and hydropower CFs are both at monthly resolution inhydcf.py, and the resultinghydcf.csvinput file (used by PRAS) is the precursor to thecf_hyd.csvdata that the adjustment factors are originally applied to.Implementation notes
runreeds.py,climateprep.pyis moved up in the input processing script order to occur right beforehydcf.py: this is necessary to have the adjustment factors processed by the time they are applied inhydcf.pyhydcf.pyhas new procedures for applying annual/seasonal climate adjustment factors to the corresponding dispatchable/non-dispatchable hydropower techsclimateprep.pyno longer creates thetemp_hydadjsea.csvfile, as it is no longer necessary to process seasonal adjustment factors inhourly_writetimeseries.py– as a result, the latter script no longer has procedures for processing the data from monthly to rep/stress-period resolutionb_inputs.gmsand2_temporal_params.gmsno longer read in or apply climate adjustment factors for hydropower CF, as they have already been applied to the CF data inhydcf.pyAdditional changes
runfiles.csv: added entries for the annual/seasonal hydropower CF climate adjustment factors,hydadjann.csvandhydadjsea.csv.Switches added/removed/changed
Issues resolved
#116: Resolves issue where climate adjustments were not being applied to stress-period data, causing hydropower CFs to equal
0for some hydro techs during stress-periods.#131: Resolves issue where climate adjustments were not reflected in the hydropower CF data used by PRAS.
Known incompatibilities
GSw_ClimateHydro) does not work out-of-the-box, as the requiredhydadjann.csv/hydadjsea.csvfiles are not currently stored in the ReEDS repo: users will need to provide their own data until updated adjustment factors are available.Relevant sources or documentation
Validation, testing, and comparison report(s)
Checklist for author
Details to double-check
hourlize/resource.pywas rerun to regenerate the existing/prescribed VRE capacity dataGeneral information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
Tag points of contact here if you would like additional review of the relevant parts of the model