fix: Make ShellCommandRunner run without root

[oSumAtrIX]

Currently, every command run by a ShellCommandRunner will be run with su (root required). With this PR, root will only be required from a RootInstaller. Also remove latest \n from shell output

[playday3008]

Related: #81

[oSumAtrIX]

how come?

[playday3008]

how come?

Wdym, how?

shellCommandRunner(GET_SDK_VERSION) ->
    shellCommandRunner("getprop ro.build.version.sdk") ->
        runCommand("su -c \'getprop ro.build.version.sdk\'")

or in better words

revanced-library/library/src/commonMain/kotlin/app/revanced/library/installation/installer/Constants.kt

Line 21 in 299c633

const val GET_SDK_VERSION = "getprop ro.build.version.sdk"

revanced-library/library/src/commonMain/kotlin/app/revanced/library/installation/installer/AdbInstaller.kt

Line 35 in 299c633

val sdkVersion = shellCommandRunner(GET_SDK_VERSION).output.toInt()

revanced-library/library/src/commonMain/kotlin/app/revanced/library/installation/installer/AdbInstaller.kt

Line 22 in 299c633

private val shellCommandRunner: ShellCommandRunner

revanced-library/library/src/commonMain/kotlin/app/revanced/library/installation/command/ShellCommandRunner.kt

Lines 56 to 58 in 299c633

	internal operator fun invoke(
	command: String,
	) = runCommand("su -c \'$command\'")

[oSumAtrIX]

What does this mean, is root required for the command?

[playday3008]

What does this mean, is root required for the command?

No, it's not required, but it still tries to, that's the problem

[oSumAtrIX]

Does this PR as it currently is fix that issue

[playday3008]

Yes, this fixes it