Fix heap-size writing unrecognized hw.heapSize property#480
Open
jramism wants to merge 1 commit into
Open
Conversation
The `heap-size` input is written to config.ini as `hw.heapSize`, which is
not a recognized AVD hardware property, so it has no effect on the emulator.
The SDK's `hardware-properties.ini` defines `vm.heapSize` ("Max VM
application heap size ... Value is in megabytes") as the property that sets
the per-app VM heap for the AVD. Write `vm.heapSize` so `heap-size` actually
takes effect. `hw.ramSize` (used for `ram-size`) is already correct and is
left unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
heap-sizeinput is written to the AVD'sconfig.iniashw.heapSize:hw.heapSizeis not a recognized AVD hardware property, so the value isignored and
heap-sizehas no effect on the emulator.The property that actually sets the per-app VM heap is
vm.heapSize, asdefined in the SDK's
emulator/lib/hardware-properties.ini:Fix
Write
vm.heapSizeinstead ofhw.heapSize.hw.ramSize(used for theram-sizeinput) is already the correct property name and is left unchanged.Related: #188
Notes
src/emulator-manager.tsand the compiledlib/emulator-manager.jschange, matching the repo convention of committing both.
output is identical to
tsc's.