Ship 0.16.0 gRPC IStreamStoreConnectionV2 over KurrentDB.Client - #259
Merged
Conversation
joshkempner
reviewed
Jul 21, 2026
joshkempner
left a comment
joshkempner
left a comment
Contributor
There was a problem hiding this comment.
The public methods on the KurrentDBConnectionWrapper and other public classes should all include XML docs.
Adopt StreamStore's conformance-tested wrapper as KurrentDBConnectionWrapper while keeping V1 SubscribeToAll defaults stable, and carry RecordedEvent.Position (#252) so mapping is done once. Co-authored-by: Cursor <cursoragent@cursor.com>
condron
force-pushed
the
chris/230-grpc-streamstore-wrapper
branch
from
July 21, 2026 19:12
fffbb68 to
2956400
Compare
joshkempner
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KurrentDBConnectionWrapper(IStreamStoreConnectionV2) adopted from StreamStore’s conformance-tested gRPC wrapper, with connection-scoped bearer/basic auth, partition interceptor, and optional TestServer handler factory.IStreamStoreConnection$alldefaults unchanged; filtered/domain-only$allis opt-in viaSubscribeToAllFiltered+StreamStoreEventFilter. CarryRecordedEvent.Position(Expose the $all position on RecordedEvent #252) through TCP and gRPC mapping.KurrentDB.Client1.2.0); add mapping/auth/interceptor/establish tests and storage-update docs/release notes.Test plan
dotnet test src/ReactiveDomain.Testing.Tests(net8.0 + net10.0)