docs(operators): add documentation for takeWhile#233
docs(operators): add documentation for takeWhile#233sumitarora merged 2 commits intoReactiveX:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 77.14% 77.14%
=======================================
Files 15 15
Lines 175 175
Branches 7 7
=======================================
Hits 135 135
Misses 40 40Continue to review full report at Codecov.
|
niklas-wortmann
left a comment
niklas-wortmann
left a comment
There was a problem hiding this comment.
Some small "changes". Rest LGTM
| name: 'takeWhile', | ||
| operatorType: 'filtering', | ||
| signature: | ||
| 'public takeWhile(predicate: function(value: T, index: number): boolean): Observable<T>', |
There was a problem hiding this comment.
@btroncone suggested to remove the generic from the signature
There was a problem hiding this comment.
@jwo719 @btroncone - Generic on the return type ? Just so I am on the page.
There was a problem hiding this comment.
@ashwin-sureshkumar @jwo719 Yes, let's leave out in signatures per #196 (comment)
| { | ||
| type: 'Tip', | ||
| text: ` | ||
| Takes values from the source only while they pass the condition given. When the first value does not satisfy, it completes. |
There was a problem hiding this comment.
I think the tip is pretty redundant to the description above.
ashwin-sureshkumar
force-pushed
the
issue-103
branch
from
fe2a028 to
e981dda
Compare
| takeWhile(ev => ev.clientX > 100) | ||
| ); | ||
| result.subscribe(x => console.log(x)); | ||
| `, |
There was a problem hiding this comment.
same here sample output?
ashwin-sureshkumar
force-pushed
the
issue-103
branch
from
e981dda to
cf25a58
Compare
|
@jwo719 @sumitarora - Done, please re-review. |
|
yay thanks @sumitarora for merging! |
6 participants
Close #103