This repository was archived by the owner on Oct 1, 2018. It is now read-only.
docs(operators): add documentation for of#265
Open
niklas-wortmann wants to merge 5 commits intoReactiveX:masterfrom
Open
docs(operators): add documentation for of#265niklas-wortmann wants to merge 5 commits intoReactiveX:masterfrom
niklas-wortmann wants to merge 5 commits intoReactiveX:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
=======================================
Coverage 90.49% 90.49%
=======================================
Files 115 115
Lines 442 442
Branches 10 10
=======================================
Hits 400 400
Misses 40 40
Partials 2 2
Continue to review full report at Codecov.
|
btroncone
suggested changes
Feb 23, 2018
Collaborator
btroncone
left a comment
There was a problem hiding this comment.
Looks good, just a few suggestions 👍
src/operator-docs/creation/of.ts
Outdated
| // ... | ||
| externalLink: { | ||
| platform: 'JSBin', | ||
| url: 'http://jsbin.com/porolatazu/embed?js,output' |
Collaborator
There was a problem hiding this comment.
I think we want console, not output in the embed http://jsbin.com/porolatazu/embed?js,console
| when those notifications will be delivered.</p> | ||
| ` | ||
| }, | ||
| examples: [ |
Collaborator
There was a problem hiding this comment.
Few things:
- It looks like you have conflicting variables with
interval - I believe you can combine the two
concat's
With update it would look something like:
const numbers = of(10, 20, 30);
const letters = of('a', 'b', 'c');
const interval$ = interval(1000);
const result = numbers.pipe(concat(letters, interval$));
result.subscribe(x => console.log(x));
Member
Author
There was a problem hiding this comment.
thanks for the feedback. Changes are pushed!
ashwin-sureshkumar
approved these changes
Mar 8, 2018
sumitarora
approved these changes
Mar 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #81