This repository was archived by the owner on Oct 1, 2018. It is now read-only.
feat(operators): Add signature based on parameters collection#284
Open
DiedrikDM wants to merge 6 commits intoReactiveX:masterfrom
Open
feat(operators): Add signature based on parameters collection#284DiedrikDM wants to merge 6 commits intoReactiveX:masterfrom
DiedrikDM wants to merge 6 commits intoReactiveX:masterfrom
Conversation
Resolve signature from name, parameters and return type values as per ReactiveX#168. This change includes an update to the OperatorDoc type, because the return type of every operator needed to be included. All existing operators have been updated as well to include the correct return type. Some updates to the css were required to add colors to the signature. Added a new pipe (ArgumentPipe) to create a nice tooltip when hovering over the arguments.
…operatorParameters
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 116 116
Lines 445 445
Branches 9 9
=======================================
Hits 404 404
Misses 40 40
Partials 1 1
Continue to review full report at Codecov.
|
Member
|
First of all thanks for this much work! I will take a look at this pr and give some feedback. |
Contributor
Author
|
@jwo719 I'm also pretty sure that a more UX proficient person (than me) should look at it. I made a couple of choices right now in the implementation, like colors and a tooltip that maybe could/should be done in an other way... |
Collaborator
|
@DiedrikDM - please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve signature from name, parameters and return type values as per #168.
This change includes an update to the OperatorDoc type, because the return type of every operator needed to be included.
All existing operators have been updated as well to include the correct return type.
Some updates to the css were required to add colors to the signature.
Added a new pipe (ArgumentPipe) to create a nice tooltip when hovering over the arguments.