This repository was archived by the owner on Oct 1, 2018. It is now read-only.
docs(operators): add documentation for windowWhen#291
Open
hardikpthv wants to merge 9 commits intoReactiveX:masterfrom
hardikpthv:iss-127
Open
docs(operators): add documentation for windowWhen#291hardikpthv wants to merge 9 commits intoReactiveX:masterfrom hardikpthv:iss-127
hardikpthv wants to merge 9 commits intoReactiveX:masterfrom
hardikpthv:iss-127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 116 116
Lines 445 445
Branches 9 9
=======================================
Hits 404 404
Misses 40 40
Partials 1 1
Continue to review full report at Codecov.
|
ashwin-sureshkumar
suggested changes
Mar 8, 2018
| const clicks = Rx.Observable.fromEvent(document, 'click'); | ||
| const result = clicks | ||
| .windowWhen(() => interval(1000 + Math.random() * 4000)) | ||
| .map(win => win.take(2)) // each window has at most 2 emissions |
Collaborator
There was a problem hiding this comment.
Please use es6 imports and pipe operator.
Member
|
@hardikpthv I think after the changes requested by ashwin, this pr can be merged. Do you need any help with this one? |
Contributor
Author
|
Sorry, @jwo719 got busy these days, so couldn't make proposed changes. Let me check this one. I will let you know in case of help. :) |
Contributor
Author
|
@jwo719, @ashwin-sureshkumar requested changes are made do let me know if anything else is required. |
niklas-wortmann
approved these changes
Apr 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #127