docs (operators): add documentation for ignoreElements#301
docs (operators): add documentation for ignoreElements#301saiprasad2595 wants to merge 4 commits intoReactiveX:masterfrom
Conversation
Generated by 🚫 dangerJS |
|
Hi @ashwin-sureshkumar I think i have an extra space after type can you squash my commit and re-correct it I am facing some problem.Also please review it and let me know for any changes. Thanks. |
btroncone
left a comment
btroncone
left a comment
There was a problem hiding this comment.
Looks good, just a few updates needed. 👍
| { | ||
| name: 'Displaying Error', | ||
| code: ` | ||
| //emit value every 100ms |
There was a problem hiding this comment.
Would you be able to update this to pipeable operators and remove global? Thanks!
| const source = Rx.Observable.interval(100); | ||
| //ignore everything but error | ||
| const error = source | ||
| .flatMap(val => { |
There was a problem hiding this comment.
Maybe use mergeMap here for consistency?
| marbleUrl: 'http://reactivex.io/rxjs/img/ignoreElements.png', | ||
| shortDescription: { | ||
| description: | ||
| 'Ignores all items emitted by the source Observable and only passes calls of `complete` or `error`' |
There was a problem hiding this comment.
May need to remove backticks here and use markdown-code class.
|
@btroncone Sorry i was sick could not push. I have updated the file with flatMap with mergeMap for consistency and used markdown class for 'complete' and 'error'. |
3 participants
close #93