This repository was archived by the owner on Oct 1, 2018. It is now read-only.
feat(i18n): setup for Chinese translation#308
Open
SangKa wants to merge 2 commits intoReactiveX:masterfrom
Open
feat(i18n): setup for Chinese translation#308SangKa wants to merge 2 commits intoReactiveX:masterfrom
SangKa wants to merge 2 commits intoReactiveX:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 90.78% 89.95% -0.84%
==========================================
Files 116 116
Lines 445 448 +3
Branches 9 9
==========================================
- Hits 404 403 -1
- Misses 40 43 +3
- Partials 1 2 +1
Continue to review full report at Codecov.
|
10 tasks
niklas-wortmann
approved these changes
Apr 27, 2018
Member
niklas-wortmann
left a comment
niklas-wortmann
left a comment
There was a problem hiding this comment.
LGTM but I can't check the translations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next step is the operators translation.