CI validation: DEV_MODE env parsing fix#4
Closed
RealDiligent wants to merge 1 commit into
Closed
Conversation
The maintainer-filter bypass was gated on `not os.environ.get('DEV_MODE')`,
which tests for presence rather than value. Every non-empty string is truthy,
so DEV_MODE=false, DEV_MODE=0, DEV_MODE=off and DEV_MODE=no all *enable* the
bypass they are meant to disable, silently dropping the maintainer filter on
a production validator.
Parse DEV_MODE by value via `dev_mode_enabled()`, alongside STORE_DB_RESULTS
in the validator config module and following the same convention. DEV_MODE=1
and DEV_MODE=true keep working, so existing setups are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal CI validation run before opening the upstream PR. Not for merge.