Skip to content

Added pre-commit hook#214

Closed
p-r-a-v-i-n wants to merge 1 commit into
RealOrangeOne:masterfrom
p-r-a-v-i-n:add-precommit
Closed

Added pre-commit hook#214
p-r-a-v-i-n wants to merge 1 commit into
RealOrangeOne:masterfrom
p-r-a-v-i-n:add-precommit

Conversation

@p-r-a-v-i-n
Copy link
Copy Markdown
Contributor

for keeping code formatting consistence in codebase added pre-commit hook

@p-r-a-v-i-n p-r-a-v-i-n marked this pull request as draft December 18, 2025 07:38
@p-r-a-v-i-n p-r-a-v-i-n force-pushed the add-precommit branch 3 times, most recently from 13dee6c to 71e5b0a Compare December 18, 2025 07:49
@p-r-a-v-i-n p-r-a-v-i-n marked this pull request as ready for review December 18, 2025 07:51
@p-r-a-v-i-n p-r-a-v-i-n marked this pull request as draft December 19, 2025 07:11
@p-r-a-v-i-n p-r-a-v-i-n marked this pull request as ready for review December 19, 2025 13:02
@p-r-a-v-i-n p-r-a-v-i-n marked this pull request as draft December 19, 2025 13:03
@p-r-a-v-i-n p-r-a-v-i-n force-pushed the add-precommit branch 12 times, most recently from 32b0449 to f999d67 Compare December 19, 2025 14:56
Comment thread .github/workflows/ci.yml
Comment on lines +12 to +13
validate:
uses: ./.github/workflows/pre-commit.yml
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now CI will only runs if code formating and or precommit was passed else it stop the other flows.
bcs currently even if there is linting errors tests jobs get executed.

ci_fails

@p-r-a-v-i-n p-r-a-v-i-n marked this pull request as ready for review December 19, 2025 15:14
@RealOrangeOne
Copy link
Copy Markdown
Owner

This just adds a few repo checks and ruff - it doesn't feel worth it to me. If it validated everything, then maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants