Fix: dark mode for teacher views#109
Merged
Merged
Conversation
- Add .bg-white and .card-header.bg-light dark mode overrides to main.css - Add dark mode media queries to inline styles in matrix.html, submissions.html, form.html - Fix hardcoded light colors that broke dark mode rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dark mode rendering issues in teacher-facing views. The problem was that several templates used hardcoded light-mode colors and Bootstrap utility classes (like
bg-white) that were not overridden in the dark mode CSS.Changes
static/css/main.css.bg-whitedark mode override (was the most widespread issue — used in submissions, conversations detail pages).card-header.bg-lightoverride to ensure proper dark shading on card headerssrc/homeworks/templates/homeworks/matrix.html@media (prefers-color-scheme: dark)block for all inline styles: matrix borders, sticky cells, summary headers/cells, status colors (submitted/in-progress/not-started/overdue), row hover effects, legend boxessrc/homeworks/templates/homeworks/submissions.html.conversations-in-sectionborder colorsrc/homeworks/templates/homeworks/form.html.section-form,.widget-form, and.field-hintcolorsTesting