Feature/publish clean#45
Merged
Merged
Conversation
…nify resource loading
- Workflow ini akan secara otomatis membangun dan meng-upload paket Python ke PyPI setiap kali ada rilis baru yang ditandai dengan tag. - Ini menggunakan GitHub Actions untuk mengotomatiskan proses tersebut, termasuk membangun distribusi, memverifikasi versi, dan akhirnya meng-upload ke PyPI. - Selain itu, ada pengecekan versi sebelumnya di PyPI untuk memastikan versi baru lebih tinggi dari versi yang ada. Langkah-langkah: 1. Workflow ini dimulai dengan penandaan tag rilis. 2. Kemudian, versi baru akan dibandingkan dengan versi terakhir di PyPI. 3. Setelah itu, distribusi paket dibangun dan di-upload ke PyPI menggunakan `pypa/gh-action-pypi-publish`. 4. Terakhir, GitHub Release akan dibuat untuk tag tersebut.
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the project structure and packaging configuration by moving from dynamic versioning to static versioning, streamlining the build process for cleaner package publishing.
- Removed dynamic version configuration and switched to static version "0.0.0"
- Simplified package structure documentation to reflect current implementation
- Enhanced GitHub Actions workflow with conditional Homebrew formula updates
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyproject.toml | Switched from dynamic to static versioning, removed CLI scripts, and added comprehensive resource patterns |
| notebooks/leksara_quickstart.ipynb | Updated notebook reference ID |
| README.md | Enhanced description for Indonesian text focus and simplified project structure documentation |
| .github/workflows/python-publish.yml | Removed PyPI version comparison logic and added conditional Homebrew tap updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.