fix: warnings in ci checks#1707
Open
swadeley wants to merge 2 commits into
Open
Conversation
Renamed to totalPagesLocator eslint rule treats any identifier starting with page as a Page object so .textContent() looked like a banned page method.
swadeley
force-pushed
the
swadeley/fix_warnings_in_ci_checks
branch
from
July 22, 2026 10:25
e087830 to
10238d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: rename pageCountLocator to stop eslint warning
Renamed to totalPagesLocator
because eslint rule treats any identifier starting with page as a Page object
so .textContent() looked like a banned page method.
fix: applied prettier text wrap & space
How to test the PR
Before the change
post-merge warnings
After the change
no more warnings
Checklist: