IUO: Fix relationship labels#4658
Merged
rnetser merged 3 commits intoRedHatQE:mainfrom May 5, 2026
Merged
Conversation
Add virt-platform-autopilot and virt-synchronization-controller to CNV pods, deployments, and operators constant lists. Signed-off-by: Harel Meir <hmeir@redhat.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
New CNV 4.22 components were missing from the deployment/pod label maps, causing test_verify_mismatch_relationship_labels to fail with missing component and StopIteration errors. Signed-off-by: Harel Meir <hmeir@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughIntroduces two new virt-related deployment constants and their label configuration mappings across the constants and test constants files. The base constants module defines the new identifiers and extends three component grouping lists, while the test constants module imports these identifiers and establishes expected label mappings for deployment annotation validation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 18 minutes and 8 seconds.Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-3
requested review from
OhadRevah,
RoniKishner,
albarker-rh,
dshchedr and
vsibirsk
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
utilities/constants.py (1)
1-1:⚠️ Potential issue | 🟠 MajorHIGH: Restore mandatory PR template sections in the PR description
The PR description is missing required template headings, which breaks review traceability and automation checks. Please restore at least:
##### What this PR does / why we need it: ##### Which issue(s) this PR fixes: ##### Special notes for reviewer: ##### jira-ticket:
What this PR does / why we need it:must contain meaningful content (not placeholder text).As per coding guidelines
**: ## PR Template Validation — required sections must be present, and “What this PR does / why we need it:” must be meaningful.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@utilities/constants.py` at line 1, The PR description is missing required template sections; update the pull request description to restore the mandatory headings "##### What this PR does / why we need it:", "##### Which issue(s) this PR fixes:", "##### Special notes for reviewer:", and "##### jira-ticket:" and ensure the "What this PR does / why we need it:" section contains meaningful, non-placeholder content describing the changes introduced (used by PR Template Validation automation); edit the PR description directly in the GitHub/GitLab UI so the validator recognizes the restored sections.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@utilities/constants.py`:
- Line 1: The PR description is missing required template sections; update the
pull request description to restore the mandatory headings "##### What this PR
does / why we need it:", "##### Which issue(s) this PR fixes:", "##### Special
notes for reviewer:", and "##### jira-ticket:" and ensure the "What this PR does
/ why we need it:" section contains meaningful, non-placeholder content
describing the changes introduced (used by PR Template Validation automation);
edit the PR description directly in the GitHub/GitLab UI so the validator
recognizes the restored sections.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: df211d88-0b70-4719-be9e-386dfb8164eb
📒 Files selected for processing (2)
tests/install_upgrade_operators/relationship_labels/constants.pyutilities/constants.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4658 +/- ##
==========================================
+ Coverage 98.63% 98.67% +0.03%
==========================================
Files 25 25
Lines 2420 2485 +65
==========================================
+ Hits 2387 2452 +65
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bug, skipping with jira api call condition Signed-off-by: Harel Meir <hmeir@redhat.com>
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/verified |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 3468 🏁 Script executed: Length of output: 41 🏁 Script executed: Length of output: 2144 🏁 Script executed: Length of output: 1759 🧠 Learnings used |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
|
/lgtm |
Contributor
Author
|
/build-and-push-container |
Contributor
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4658 published |
Contributor
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #3748. Overlapping filesutilities/constants.py |
rnetser
reviewed
Apr 30, 2026
Collaborator
|
/approve |
Contributor
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #4725. Overlapping filesutilities/constants.py |
Contributor
Author
|
/check-can-merge |
|
Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-4658. |
This was referenced May 5, 2026
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Add new constants, relationship labels
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
https://redhat.atlassian.net/browse/CNV-86100
Summary by CodeRabbit