fix: skip remote variable collections when matching by name#266
Open
phiilu wants to merge 1 commit intoRedMadRobot:masterfrom
Open
fix: skip remote variable collections when matching by name#266phiilu wants to merge 1 commit intoRedMadRobot:masterfrom
phiilu wants to merge 1 commit intoRedMadRobot:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
variablesColors, the Figma REST API (GET /v1/files/:id/variables/local) returns both local and remote (library-subscribed) variable collections.If a remote collection shares the same name as a local one,
.first(where:)may match the remote collection instead, which in my org contains fewer variables, leading to silently missing colors in the export.Fix: Decode the
remotefield from the API response onVariableCollectionValueand filter it out during collection lookup:The remote field is documented by Figma (https://developers.figma.com/docs/rest-api/variables-types/#variablecollection-type) as: