Conversation
TheAndrey
reviewed
Feb 17, 2025
TheAndrey
left a comment
TheAndrey
left a comment
There was a problem hiding this comment.
В целом неплохо. Есть что улучшить.
src/main/java/mcp/mobius/waila/addons/thermalexpansion/HUDHandlerCache.java
Outdated
Show resolved
Hide resolved
src/main/java/mcp/mobius/waila/addons/thermalexpansion/HUDHandlerCache.java
Outdated
Show resolved
Hide resolved
src/main/java/mcp/mobius/waila/addons/thermalexpansion/HUDHandlerCache.java
Outdated
Show resolved
Hide resolved
src/main/java/mcp/mobius/waila/addons/thermalexpansion/ThermalExpansionModule.java
Outdated
Show resolved
Hide resolved
src/main/java/mcp/mobius/waila/addons/thermalexpansion/ThermalExpansionModule.java
Outdated
Show resolved
Hide resolved
Author
|
Суть понял. Продолжаю доабвлять полную поддержку модов |
|
Закончите с этими двумя. Для остальных новый PR. Есть пример реализации с 1.7.10 |
Author
|
Именно на этот пример и ориентировался. Не нашел только исходники ic2c, поэтому ориентировался на декомпилированный с сервера |
- Удалены лишние языковые файлы
- Доработка модуля ic2:
- Удален лишний код
- Переименованны переменные
- Доработка модуля te:
- Удален лишний код
- Переименованы переменные
- Изменен способ получения данных о предмете
TheAndrey
requested changes
Feb 17, 2025
TheAndrey
left a comment
TheAndrey
left a comment
There was a problem hiding this comment.
Зачем переводы было удалять? Недостающие строки берутся из базового перевода En_US.
src/main/java/mcp/mobius/waila/addons/thermalexpansion/HUDHandlerCache.java
Outdated
Show resolved
Hide resolved
src/main/java/mcp/mobius/waila/addons/ic2/HUDHandlerTEGenerator.java
Outdated
Show resolved
Hide resolved
TheAndrey
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавлены мини-аддоны для ic2 и te.