feat: lighthouse data-element tag on draftjs#5
Merged
SaraBianchi merged 3 commits intodevelopfrom Nov 30, 2022
Merged
Conversation
Bundle size diff
|
|
Aggiustato tooltip per inserimento di link e data element in draftJs
@Wagner3UB ti aggiungo qui se vuoi fare anche tu test e review. |
|
@pnicolli @SaraBianchi Per conoscenza: Ho provato a impostare gli altri stili (bold, italico ecc) un pó a caso e ogni tanto il data-element sparisce. Basta re-impostarlo però che ricompare e si vede perfettamente. Come è un strumento a uso nostro, interno, basta che Baio e Nicola sappiano di questo piccolissimo bug. Penso anche che non ci saranno mille stile su un link al footer, ma non si sa mai. Non solo, penso che il problema sia impostare gli altri stili dopo impostato data-element |
Wagner3UB
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Riportata da RedTurtle/design-volto-theme#613