Skip to content

Fix mac release packaging#1245

Merged
Arctis-Fireblight merged 2 commits intoRedot-Engine:masterfrom
Arctis-Fireblight:fix-mac-release-packaging
Apr 26, 2026
Merged

Fix mac release packaging#1245
Arctis-Fireblight merged 2 commits intoRedot-Engine:masterfrom
Arctis-Fireblight:fix-mac-release-packaging

Conversation

@Arctis-Fireblight
Copy link
Copy Markdown
Contributor

@Arctis-Fireblight Arctis-Fireblight commented Apr 26, 2026

Fixed multiple issues with Mac signing for the editor and the mono release templates.

Fixes #1186 by bumping the version in the template app.

Fixes #1244 by removing the _mono_suffix environment variable from the destination file copy operation in the signing stage, so that the paths for the executables end up the same location for the mono version as the standard version.
This behavior is required for the mono version of the editor to be able to find the export template and properly export a game.

Summary by CodeRabbit

  • Chores
    • Simplified macOS template binary staging by using consistent fixed filenames for universal templates during the signing process, improving consistency across build variants.

…lates Redot-EngineGH-1244

The signing scrips keep the `.mono` extension when signing the Mac templates. However, the editor expects them to be named the same as the non-mono versions leading to a broken template file.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 597c49a5-e9c8-4bbf-9335-96537b65c3b3

📥 Commits

Reviewing files that changed from the base of the PR and between 5f54c0d and 2a4a5fb.

⛔ Files ignored due to path filters (1)
  • misc/dist/macos_tools.app/Contents/Info.plist is excluded by !**/dist/**
📒 Files selected for processing (1)
  • .gitlab-ci.yml

Walkthrough

The macOS template signing step in the CI/CD pipeline now uses fixed destination filenames for universal binaries (redot_macos_release.universal and redot_macos_debug.universal) when staging templates, removing the dynamic mono suffix from the destination paths.

Changes

Cohort / File(s) Summary
CI/CD Configuration
.gitlab-ci.yml
Modified macOS template signing step to use fixed filenames instead of embedding ${_mono_suffix} into destination filenames, ensuring universal binaries are staged consistently regardless of build type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix mac release packaging' is concise and directly related to the main changes in the pull request, which address Mac signing and packaging issues for both editor and templates.
Linked Issues check ✅ Passed The pull request addresses both linked issues: it removes the _mono_suffix from destination filenames (#1244) and updates version metadata in the template app (#1186) for correct Mac app packaging.
Out of Scope Changes check ✅ Passed The changes are narrowly focused on the .gitlab-ci.yml file, specifically the Mac template signing step, which is directly relevant to the stated objectives of fixing Mac release packaging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Arctis-Fireblight Arctis-Fireblight merged commit c9e566c into Redot-Engine:master Apr 26, 2026
17 checks passed
@Arctis-Fireblight Arctis-Fireblight deleted the fix-mac-release-packaging branch April 26, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant