Fix mac release packaging#1245
Conversation
…lates Redot-EngineGH-1244 The signing scrips keep the `.mono` extension when signing the Mac templates. However, the editor expects them to be named the same as the non-mono versions leading to a broken template file.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe macOS template signing step in the CI/CD pipeline now uses fixed destination filenames for universal binaries ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixed multiple issues with Mac signing for the editor and the mono release templates.
Fixes #1186 by bumping the version in the template app.
Fixes #1244 by removing the
_mono_suffixenvironment variable from the destination file copy operation in the signing stage, so that the paths for the executables end up the same location for the mono version as the standard version.This behavior is required for the mono version of the editor to be able to find the export template and properly export a game.
Summary by CodeRabbit