Open
Conversation
Documentation build overview
Show files changed (6 files in total): 📝 5 modified | ➕ 0 added | ➖ 1 deleted
|
agitter
reviewed
Feb 24, 2026
Comment on lines
+196
to
+198
| # We get protein1, protein2, and cost if no edges were inside the solution, | ||
| # and we get protein1, protein2 if no edges were present in the augmented forest at all: | ||
| # both of these outcomes should be treated as an empty network. |
Collaborator
There was a problem hiding this comment.
@ntalluri there were multiple OI2 failure modes you observed. Can you please confirm this comment is accurate with respect to your past tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was very confused by what 'corrupted data' meant in OI2. Hopefully this saves the next reader some time digging through the OmicsIntegrator2 codebase.
While we're here, we also pin the defaults using values provided by OI2, and move dummy_mode documentation over to the enum instead of on the parameter class directly.