Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cast_header_tにmax_payloadフィールド(2B)を追加し、受信側がオフセット計算に利用できるようにしたcast_reassembler.cを実装。チャンク順不同での受信・組み立てに対応し、完成時にコールバックで通知するcast_init_receiver()/cast_reassembler_reset()をcast_protocol.hに追加max_payload対応に修正Changes
src/cast_internal.h:cast_header_tにmax_payloadフィールド追加、CAST_CRC_SIZE/CAST_PROTOCOL_OVERHEAD定数追加src/cast_chunker.c:max_payloadフィールドへの書き込みを追加src/cast_reassembler.c: 新規。ダイレクトマッピング方式で順不同チャンクを組み立て、バッファはミドルウェア側で管理・解放include/cast_protocol.h:cast_on_frame_ready_t,cast_init_receiver(),cast_reassembler_reset()を公開test/host/test_cast_reassembler.cpp: 15テスト（ループバック、順序、異常系、フォーマット伝搬、サイズ検証）test/host/test_cast_chunker.cpp:max_payload追加に伴うテスト修正Test plan