Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdcard_write(path, data, len)するだけで正しいファイルが保存できるMotivation
受信側のアプリが「画像ファイルが来たら保存するだけ」で済むようにしたい。
ファイルヘッダの生成ロジックをアプリに書くと、送信側と同じ問題（忘れる・重複する）が起きる。
Reassembler は fmt・width・height を全部知っているので、ここでヘッダを付与するのが最も自然。
Changes
src/cast_reassembler.c:build_bmp_rgb565(): BMP ファイル生成 (FileHeader + InfoHeader + ColorMasks + 4byte行パディング)build_pgm_grayscale(): PGM (P5) ファイル生成fmtに応じて分岐し、ヘッダ付きデータをコールバックに渡すtest/host/test_cast_reassembler.cpp:BmpHeaderRgb565: BMP signature, ファイルサイズ, bpp, ピクセルデータ一致を検証PgmHeaderGrayscale: PGM ヘッダ文字列, ピクセルデータ, 全体サイズを検証FormatPropagation: 各フォーマットのヘッダ先頭バイトを確認Test plan