revamp: tried some design changes#261
Open
EswaramoorthyKarthikeyan wants to merge 4 commits intoRejectedus:masterfrom
Open
revamp: tried some design changes#261EswaramoorthyKarthikeyan wants to merge 4 commits intoRejectedus:masterfrom
EswaramoorthyKarthikeyan wants to merge 4 commits intoRejectedus:masterfrom
Conversation
This commit introduces a new `Story` component to encapsulate the rendering logic for individual stories. Key changes: - Created `src/Story.js` which now handles the presentation of a single story. - The `Story` component receives a `story` object as a prop. - It also accounts for the `story.double` property, allowing for potential future layout variations based on this flag. - Refactored `src/App.js` to import and use the new `Story` component, simplifying `App.js` and improving modularity. This refactoring enhances code organization and readability.
This commit significantly revises the README.md to provide clear and concise information about the Rejected.us project. Key updates include: - Added a project title and a brief description of its purpose. - Detailed the project structure, highlighting key components like `App.js`, `Story.js`, and the data source `src/data/stories.js`. - Provided clear, step-by-step instructions for contributing new stories, including data format and image placement. - Condensed the "Available Scripts" section to focus on essential commands (`npm start`, `npm test`, `npm run build`). - Retained links to Create React App and React documentation for further learning. The updated README aims to be more helpful for you and potential contributors.
…story-component Refactor/extract story component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed card style
entire body style and scroll container related changes
font style added