Port upstream Muya cpp alias idempotence#58
Open
Renakoni wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports upstream marktext/marktext PR #4816 into the Android Muya copy.
Upstream source: marktext/marktext#4816
This is a follow-up to upstream #4794, so this Android PR is intentionally stacked on Android PR #54 (
sync/upstream-4794-cpp-alias). It keeps the one-upstream-PR-to-one-Android-PR mapping while avoiding a misleading PR againstmainbefore the alias registration exists there.Changes
c++/h++alias registration idempotent by adding each alias only when it is absent.Verification
pnpm test -- src/utils/prism/__tests__/languageAlias.spec.tsfromthird_party/muyapassed: 5 tests.pnpm exec eslint src/utils/prism/index.ts src/utils/prism/__tests__/languageAlias.spec.ts --no-ignore --max-warnings 0fromthird_party/muyapassed.pnpm typecheckfrom repo root passed.Audit Decision
This upstream PR is Android-relevant because it hardens the Muya Prism initialization path used by the Android WebView editor. It depends on the alias registration ported in Android PR #54, so this PR targets that branch rather than
main.