Port upstream Mermaid export resilience fix#63
Open
Renakoni wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream Source
Android Relevance
The Android repo carries Muya's
MarkdownToHtmlexport implementation and its export tests. This bug is in that shared Muya path:MarkdownToHtml._renderMermaid()batched all Mermaid nodes into onemermaid.run()call, so a syntax error in one diagram rejected the entire render operation. Even though Android's current user-facing export surface is limited, keeping the embedded Muya export path correct avoids shipping a known upstream Muya failure in the codebase.Change Details
mermaid.run({ nodes })call to one isolated run per Mermaid node.< Invalid Diagram >, matching the existing non-Mermaid diagram export fallback.mermaidExportResilience.spec.tscovering:renderHtml();Verification
pnpm --dir third_party/muya exec vitest run src/state/__tests__/mermaidExportResilience.spec.tspassed.pnpm buildpassed.