Port upstream table escaped pipe fix#67
Open
Renakoni wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|/||instead of\|/\|\|.Upstream Source
Android Relevance
This directly affects Android's live Muya editor rendering. GFM table cells escape literal pipes as
\|; after parsing, that escape should be stored as a literal pipe. The previous import path re-added\|into the stored table-cell text. That looked acceptable in plain cell text because the inline escape rule hides the backslash, but inside inline code the backslash is literal, so Android users saw code cells like\|instead of|.Change Details
MarkdownToState.\|already resolved to literal|.stateToMarkdown.escapeTextserialization path, which re-escapes pipes when writing markdown.tableEscapedPipe.spec.tscovering:`\|`and`\|\|`;Verification
pnpm --dir third_party/muya exec vitest run src/state/__tests__/tableEscapedPipe.spec.tspassed.pnpm buildpassed.