Port upstream code fence info string fix#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream Source
Android Relevance
This affects Android document saving. Android uses Muya's state import/export pipeline to edit and serialize markdown. Before this fix, fenced code block info strings were reduced to the first word when saved: for example
```js title="app.js"became```js, and Pandoc/RMarkdown attribute blocks like```{example, listing1-name}were truncated. That is data loss in Android-edited markdown files.Change Details
meta.langas the first info-string word for highlighting and language class behavior.meta.infowhen it carries more thanlang.meta.infoonly while its first word still matchesmeta.lang; if the language is later edited, the edited language wins and stale attributes are not re-emitted.codeFenceInfoString.spec.tsfor the round-trip and stale-info cases.Verification
pnpm --dir third_party/muya exec vitest run src/state/__tests__/codeFenceInfoString.spec.ts src/state/__tests__/codeFenceLength.spec.tspassed.pnpm buildpassed.