Port upstream extensionless image content type fix#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
Ports marktext/marktext#4857: marktext/marktext#4857
Android relevance
Android uses Muya image rendering inside the WebView editor. Extensionless remote badge URLs such as
https://img.shields.io/badge/example-bluego through the samegetImageSrc/loadImagepath, so rejectingimage/svg+xml;charset=utf-8or treating an unreadable cross-origin HEAD as "not an image" breaks visible editor content on mobile too.Changes
Content-Typebefore matching, soimage/svg+xml;charset=utf-8is accepted.nullfromcheckImageContentType()when the type cannot be determined, rather than collapsing network/CORS/CSP failures intofalse.<img>load to decide.loadImagefallback.Verification
pnpm --dir third_party/muya exec vitest run src/utils/__tests__/image.spec.tspnpm build