Port upstream flush before save guard#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
Ports the Android-relevant behavior from marktext/marktext#4859: marktext/marktext#4859
Upstream fixed a save-path race where Muya can still have a same-frame edit queued in its rAF/json-state batch when the host snapshots markdown for persistence.
Android relevance
Android does not have the desktop Pinia
FILE_SAVE/ IPC path, but it does readeditor.getMarkdown()for the same persistence boundary:Muya already exposes
flush()in this fork, and its ownflushPendingOps.spec.tsprovesgetMarkdown()can be stale untilflush()is called. This PR applies the upstream invariant to Android's save snapshots: flush first, then read markdown.Changes
readEditorMarkdownSnapshot()helper that can flush before reading and normalize the result.flush()method to the local@muyajs/coretype declaration.flush()is called beforegetMarkdown()for save-style snapshots, and that non-save reads remain unflushed.Verification
pnpm vitest run src/features/editor/editorMarkdownSnapshot.test.ts src/features/android-documents/saveAndroidDocumentWorkflow.test.ts src/features/android-documents/saveLocalDraftToAndroidDocumentWorkflow.test.ts src/features/android-documents/saveAndroidDocumentCopyWorkflow.test.ts src/features/android-documents/shareAndroidMarkdownDocumentWorkflow.test.tspnpm build