feat: use paper_id for artifact URL lookups#13
Merged
Conversation
- Add artifactByPaperId map built from artifacts.json paper_id field - Add getArtifactUrl() helper: paper_id lookup with title fallback - Institution profile uses getPapers() + getArtifactUrl() instead of iterating embedded p.papers with title-based matching - Requires reprodb-pipeline v0.2.0 data format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update profile page JS to use paper_id-based artifact URL lookups instead of title-based matching.
Changes
artifactByPaperIdmap built fromartifacts.jsonpaper_idfieldgetArtifactUrl(paper)helper: looks up bypaper.idfirst, falls back tonormalizeTitle()for backward compatibilitygetPapers()+getArtifactUrl()instead of iterating embeddedp.paperswith title matchinggetArtifactUrl()instead of directartifactUrlMaptitle lookupDependencies
Requires reprodb-pipeline v0.2.0 data format (ReproDB/reprodb-pipeline PR with
paper_idinartifacts.jsonandpaper_idsinauthor_profiles.json).Backward Compatibility
The
getArtifactUrl()helper falls back to title-based lookup whenpaper_idis not present, so the website works with both old and new data formats during the transition.