Skip to content

fix: prevent white overlay when mobile burger menu opens #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vahldiek wants to merge 1 commit into from
Closed

fix: prevent white overlay when mobile burger menu opens #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion src/_includes/head/custom.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,24 @@
<link rel="apple-touch-icon" href="{{ '/assets/images/favicon.svg' | relative_url }}">

<!-- Alpine.js x-cloak: hide elements until Alpine initializes -->
<style>[x-cloak] { display: none !important; }</style>
<!-- Kill Minimal Mistakes greedy-nav full-screen white backdrop overlay.
The theme's @supports rule (pointer-events:none) creates a fixed, page-wide
white ::before on .greedy-nav__toggle.close. We use Alpine.js for the menu,
so this overlay just blocks the page on mobile. -->
<style>
[x-cloak] { display: none !important; }
.greedy-nav__toggle::before,
.greedy-nav__toggle.close::before {
display: none !important;
content: none !important;
}
/* Prevent theme's .close class from hiding the navicon */
.greedy-nav__toggle.close .navicon,
.greedy-nav__toggle.close .navicon::before,
.greedy-nav__toggle.close .navicon::after {
background: currentColor !important;
}
</style>

<!-- Prevent FOUC: apply saved theme before any paint -->
<script>
Expand Down Expand Up @@ -55,3 +72,15 @@
scripts so Tabulator + ECharts are available when Alpine processes
x-data directives and calls component boot() functions. -->
<script defer src="https://cdn.jsdelivr.net/npm/alpinejs@3/dist/cdn.min.js"></script>

<!-- Neutralise Minimal Mistakes greedy-nav jQuery click handler.
The theme's JS toggles .close on the burger button and shows .hidden-links,
causing a white overlay. We use Alpine.js instead; unbind jQuery's handler
after all scripts have loaded so it cannot interfere. -->
<script>
window.addEventListener('load', function() {
if (window.jQuery) {
jQuery('nav.greedy-nav .greedy-nav__toggle').off('click');
}
});
</script>
8 changes: 8 additions & 0 deletions src/assets/css/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,14 @@ html {
border: none;
padding: 4px 8px;
color: #333;

// Disable the theme's full-screen white backdrop overlay.
// The theme uses ::before on .greedy-nav__toggle.close to create a page-wide
// white overlay when .hidden-links is shown. Since we use Alpine.js for the
// hamburger menu instead, this overlay just blocks the page.
&::before {
display: none !important;
}
}

// Desktop (≥768px): show all items, keep hamburger visible
Expand Down