Document Sketcher edit value menu text rename (#213)#237
Open
18060910075zx-coder wants to merge 2 commits into
Open
Document Sketcher edit value menu text rename (#213)#23718060910075zx-coder wants to merge 2 commits into
18060910075zx-coder wants to merge 2 commits into
Conversation
Owner
|
This didn't seem necessary to me. @Roy-043, do you think these kinds of text changes should be included in release notes pages? |
|
The change to the Sketcher Workbench been is correct. But mentioning such minor things in the Release Notes does not make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #213.
Two changes:
Sketcher Workbench page (
Sketcher_Workbench.wikitext): Updated the edit-constraints instructions to use the currentEdit valuecontext-menu label instead of the oldChange value.Release notes 1.2 (
Release_notes_1.2.wikitext): Added a bullet documenting that the task-panel action was renamed from "Change value" to "Edit value" for consistency with the 3D View context menu (Sketcher: change 'Change Value' to 'Edit Value' in task panel FreeCAD/FreeCAD#29556).Contributes to #30.