Use ShellExecute to run emulators on Win32#701
Open
raelgc wants to merge 2 commits intoRetroPie:masterfrom
Open
Use ShellExecute to run emulators on Win32#701raelgc wants to merge 2 commits intoRetroPie:masterfrom
raelgc wants to merge 2 commits intoRetroPie:masterfrom
Conversation
Author
|
Ok, just tested with a lot of different commands, and this is not properly handling arguments. I'll improve it (and close this PR for now). |
Author
|
Now I'm using |
Author
|
I tested this in a different Windows box: it requires a newest version of Microsoft Visual C++ Redistributable: the 2015 x86 version. |
Author
|
@o-p-a Your PR is address several issues with the multibyte support! Nice! For some reason, I missed it, sorry! My solution relied on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of the
systemcall, not requiring acmdprompt to run emulators.It has better flexibility, because it behaves like a user double clicking on an app.
@jrassa During the Windows environment configuration, I got almost all dependencies (
freetype,freeimage,curlandrapidsjon) installed usingvspkg. Onlylibvlcwas required to be manually downloaded.Do you think it's worth document my building process using
vspkg? While it requires VS Studio 2019 setup to install C++ core libraries, I followed yourMSBuildcommands from the CI config in your repo (i.e., the build/compile process is all command line).