input: export additional info for joysticks inputs#797
Merged
joolswills merged 1 commit intoRetroPie:masterfrom Apr 11, 2023
Merged
input: export additional info for joysticks inputs#797joolswills merged 1 commit intoRetroPie:masterfrom
joolswills merged 1 commit intoRetroPie:masterfrom
Conversation
Added some extra info to help RetroPie's auto-configuration scripts by exporting the joystick Vendor and Product IDs, which should help with RetroArch's joypad profile generation. Since 2.0.14, SDL's joystick name (`SDL_CreateJoystickName`) is a normalized version of the name reported by the OS (culled consecutive spaces, trimming trailing spaces, renaming known joystick names like Xbox/PS). This breaks the input auto-configuration scripts in RetroPie, which generate a config with new name, while the emulators/ports expect to find the OS reported name (e.g. RetroArch - see #3398 [1] for an example). This issue is affecting especially PC users, which are not using RetroPie's (old) SDL version and who's RetroArch configuration is incomplete. Using the Vendor/Product ID would help these situations and support the new SDL versions when added to RetroPie. [1] RetroPie/RetroPie-Setup#3398
cmitu
force-pushed
the
sdl-vendored-input
branch
from
b6e4c76 to
9473f19
Compare
Author
|
I simplified a bit the additions, exporting only the device's vendor and product IDs. NOTE: I think merging this would break #808, unfortunately. |
Member
|
Thanks. |
fengjixuchui
added a commit
to fengjixuchui/EmulationStation
that referenced
this pull request
Apr 13, 2023
Merge pull request RetroPie#797 from cmitu/sdl-vendored-input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some extra info to help RetroPie's auto-configuration scripts by exporting the joystick Vendor and Product IDs, which should help with RetroArch's joypad profile generation.
Since 2.0.14, SDL's joystick name (
SDL_CreateJoystickName) is a normalized version of the name reported by the OS (culled consecutive spaces, trimming trailing spaces, renaming known joystick names like Xbox/PS). This breaks the input auto-configuration scripts in RetroPie, which generate a config with new name, while the emulators/ports expect to find the OS reported name (e.g. RetroArch - see #3398 [1] for an example).This issue is affecting especially PC users, which are not using RetroPie's (old) SDL version and who's RetroArch configuration is incomplete.
Using the Vendor/Product ID would help these situations and support the new SDL versions when added to RetroPie.
[1] RetroPie/RetroPie-Setup#3398