Fix #641: Main menu and game list options menu now loop. #896
Fix #641: Main menu and game list options menu now loop. #896RobertoOropezaG wants to merge 1 commit intoRetroPie:masterfrom
Conversation
…hen you are on top menu item and push up button you go to last menu item.
|
Thank you for sending this over and for engaging in the issue. I can't promise I'll pick this up in the coming days as I have limited availability, but I'll eventually review and get to it. One thing that helps, if you haven't done so yet, is to share this in the forums so others can also test it in the meantime. Looking at the code I don't have any meaningful objection, just a question that I'll ask in context. EDIT: nevermind, no questions to ask. Thanks! |
|
Note: it also solves this duplicated issue #566 |
|
Hi there! Sorry for the delay here. So, I was testing it and it works well on the top menu - thank you. Two questions: a) The PAGE DOWN and PAGE UP behavior is unexpected, though. I'd rather have it not cause the loop and just go to the end/beginning of the list. As it stands, when you press PAGE DOWN it ends up selecting the element above the current item, and the opposite for PAGE UP. Thoughts on that? This one I'd like to see changed at least. Thanks for this once again! |
Main menu and game list options menu now loop, so when you are on top menu item and push "up" button you go to last menu item, and from last you go to the first item.
Added new default parameter
ListLoopType loop_type = LIST_NEVER_LOOPto ComponentList and MenuComponent constructors, and use it in GuiGamelistOptions and GuiMenu.