Skip to content

[Galaxy Store]: Remove @Experimental annotations from Galaxy Module#3494

Open
fire-at-will wants to merge 11 commits into
mainfrom
remove-experimental-annotations-from-galaxy
Open

[Galaxy Store]: Remove @Experimental annotations from Galaxy Module#3494
fire-at-will wants to merge 11 commits into
mainfrom
remove-experimental-annotations-from-galaxy

Conversation

@fire-at-will
Copy link
Copy Markdown
Contributor

@fire-at-will fire-at-will commented May 19, 2026

Description

Removes the @ExperimentalPreviewRevenueCatPurchasesAPI annotations from public Galaxy classes to prepare for a GA release.

Will merge + release in parallel with #3492


Note

High Risk
High risk because it changes the public Galaxy API surface (removes @ExperimentalPreviewRevenueCatPurchasesAPI and replaces GalaxyBillingMode enum with a class-like type), which can affect source/binary compatibility and reflection-based integrations.

Overview
Prepares the Galaxy module for GA by removing @ExperimentalPreviewRevenueCatPurchasesAPI from public Galaxy-facing types and from PurchasesConfiguration.Builder.galaxyBillingMode/galaxyBillingMode property.

Updates GalaxyBillingMode from an enum to an abstract class with @JvmField singleton instances, adjusts when/conversion logic to handle non-exhaustive cases (including throwing PurchasesException for unsupported modes), and updates sample/test code and reflection usage accordingly (e.g., fetching TEST via getField).

Reviewed by Cursor Bugbot for commit 4203e49. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.89%. Comparing base (0857296) to head (4203e49).

Files with missing lines Patch % Lines
...m/revenuecat/purchases/galaxy/GalaxyBillingMode.kt 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3494      +/-   ##
==========================================
- Coverage   79.89%   79.89%   -0.01%     
==========================================
  Files         369      369              
  Lines       14871    14875       +4     
  Branches     2048     2048              
==========================================
+ Hits        11881    11884       +3     
- Misses       2157     2158       +1     
  Partials      833      833              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fire-at-will fire-at-will marked this pull request as ready for review May 19, 2026 15:34
@fire-at-will fire-at-will requested a review from a team as a code owner May 19, 2026 15:34
@fire-at-will fire-at-will changed the title Remove @Experimental annotations from Galaxy Module [Galaxy Store]: Remove @Experimental annotations from Galaxy Module May 20, 2026
Copy link
Copy Markdown
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to finally release this as stable! As mentioned, I do think it would be ideal to remove the "sealed" moving forward (we should add some linter to catch these moving forward). Lmk what you think!

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 14c3cb1. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants