Add WorkflowType enum with feedback-survey support#3495
Draft
facumenzella wants to merge 1 commit into
Draft
Conversation
Port of RevenueCat/purchases-ios#6815 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of RevenueCat/purchases-ios#6815
Summary
WorkflowTypeenum (PAYWALL,WEB_FUNNEL,FEEDBACK_SURVEY,UNKNOWN) toWorkflowModels.ktworkflowType: WorkflowType?field toPublishedWorkflowso the Android SDK can identify feedback-survey workflows from the backend responseUNKNOWNviaEnumDeserializerWithDefaultwith an explicit key map (required because "web-funnel" and "feedback-survey" use hyphens, not underscores)nullfor backwards compatibilityDeviations from iOS
WorkflowTriggerTypealso silently falls back toUNKNOWN)Test plan
WorkflowTypeDeserializationTestscovers all 3 known types, unknown type →UNKNOWN, and future unknown string →UNKNOWNPublishedWorkflowTestcovers JSON decoding of all 3 known types, unknown string →UNKNOWN, and missing field →null./gradlew :purchases:testDefaultsBc8DebugUnitTest --tests "com.revenuecat.purchases.common.workflows.*"passes🤖 Generated with Claude Code