fix unit tests#275
Open
samussiah wants to merge 14 commits into
Open
Conversation
pburnsdata
suggested changes
Feb 7, 2020
Contributor
There was a problem hiding this comment.
@samussiah This might be fine, but I was confused about the purpose of testNew.js and why sortTable was removed and createTable added
Contributor
Author
|
@pburnsdata testNew is only for trying out new unit tests. It's not actually part of the test suite. |
Contributor
|
@samussiah You can't lie to me spencer - I know what's really going on in the test suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Closes #274