Skip to content

enabled uv, needs some cleanup#9

Open
btyeung wants to merge 3 commits intoRichardAtCT:mainfrom
btyeung:main
Open

enabled uv, needs some cleanup#9
btyeung wants to merge 3 commits intoRichardAtCT:mainfrom
btyeung:main

Conversation

@btyeung
Copy link

@btyeung btyeung commented Jul 12, 2025

Here is the pull request per issue. Enabling UV.

Cheers
BY

Copy link
Owner

@RichardAtCT RichardAtCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR adding UV and Docker support! I've reviewed the changes and have some feedback:

🎯 Summary

This PR introduces UV package manager support alongside Poetry and adds Docker containerization. However, there are a few items that need attention before merging.

🔍 Key Findings

1. Breaking Change Alert 🚨

The default value of enable_tools has been changed from False to True in src/claudewrapper/claude_wrapper.py. This is a breaking change that could affect existing integrations expecting the previous behavior.

2. Merge Conflicts

The PR currently has merge conflicts that need to be resolved.

3. Python Version Mismatch

  • Dockerfile specifies Python 3.13
  • pyproject.toml requires Python ^3.10
  • This inconsistency could cause issues

4. Docker Optimization Opportunity

Consider adding a .dockerignore file to exclude unnecessary files from the Docker build context (e.g., .git, __pycache__, .pytest_cache, etc.)

📋 Recommendations

  1. For the breaking change, consider one of these options:

    • Revert enable_tools default back to False to maintain backward compatibility
    • OR bump the version to 2.0.0 to indicate a major breaking change and document it clearly
  2. Resolve merge conflicts with the main branch

  3. Align Python versions - update the Dockerfile to use Python 3.10 to match pyproject.toml

  4. Add documentation for:

    • Migration guide from Poetry to UV
    • Docker usage instructions
    • The rationale for the enable_tools default change
  5. Add .dockerignore file with common exclusions

💡 Suggested .dockerignore

.git
.github
__pycache__
*.pyc
*.pyo
*.pyd
.Python
.pytest_cache
.coverage
*.log
.env
.venv
venv/

Let me know if you need help with any of these changes! The UV and Docker additions are valuable improvements to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants