Conversation
RichardAtCT
left a comment
There was a problem hiding this comment.
Thank you for this PR adding UV and Docker support! I've reviewed the changes and have some feedback:
🎯 Summary
This PR introduces UV package manager support alongside Poetry and adds Docker containerization. However, there are a few items that need attention before merging.
🔍 Key Findings
1. Breaking Change Alert 🚨
The default value of enable_tools has been changed from False to True in src/claudewrapper/claude_wrapper.py. This is a breaking change that could affect existing integrations expecting the previous behavior.
2. Merge Conflicts
The PR currently has merge conflicts that need to be resolved.
3. Python Version Mismatch
Dockerfilespecifies Python 3.13pyproject.tomlrequires Python ^3.10- This inconsistency could cause issues
4. Docker Optimization Opportunity
Consider adding a .dockerignore file to exclude unnecessary files from the Docker build context (e.g., .git, __pycache__, .pytest_cache, etc.)
📋 Recommendations
-
For the breaking change, consider one of these options:
- Revert
enable_toolsdefault back toFalseto maintain backward compatibility - OR bump the version to 2.0.0 to indicate a major breaking change and document it clearly
- Revert
-
Resolve merge conflicts with the main branch
-
Align Python versions - update the Dockerfile to use Python 3.10 to match pyproject.toml
-
Add documentation for:
- Migration guide from Poetry to UV
- Docker usage instructions
- The rationale for the
enable_toolsdefault change
-
Add
.dockerignorefile with common exclusions
💡 Suggested .dockerignore
.git
.github
__pycache__
*.pyc
*.pyo
*.pyd
.Python
.pytest_cache
.coverage
*.log
.env
.venv
venv/
Let me know if you need help with any of these changes! The UV and Docker additions are valuable improvements to the project.
Here is the pull request per issue. Enabling UV.
Cheers
BY