PyPi Intergration#37
Open
yeslayla wants to merge 9 commits into
Open
Conversation
Update to work with PyPI Fix pipeline Update pipeline Update pipeline Update pipeline
yeslayla
commented
Jan 20, 2020
| # Versions should comply with PEP440. For a discussion on single-sourcing | ||
| # the version across setup.py and the project code, see | ||
| # https://packaging.python.org/en/latest/single_source_version.html | ||
| name='semver-by-branch', |
Contributor
Author
There was a problem hiding this comment.
If we need to change the package name, that only has to be updated here.
dejonghe
previously requested changes
Jan 21, 2020
dejonghe
left a comment
dejonghe
left a comment
There was a problem hiding this comment.
Everything looks good but the jenkins file doesnt look like it'll work, if it builds currently it may be because of prior builds having artifacts left around
PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library PIPELINE: Use jenkin's docker library
yeslayla
force-pushed
the
hotfix/packageName
branch
from
27879ae to
34f58b7
Compare
dejonghe
suggested changes
Jun 15, 2020
| sh "python setup.py sdist" | ||
|
|
||
| stash includes: "dist/semver-${env.SEMVER_NEW_VERSION}.tar.gz", name: 'PACKAGE' | ||
| script |
Contributor
Author
There was a problem hiding this comment.
Required for dockerImage and docker.build
| docker push rightbrainnetworks/auto-semver:${env.VERSION} | ||
| """) | ||
| sh("docker login -u ${DOCKER_USERNAME} -p ${DOCKER_PASSWORD}") | ||
| script |
Contributor
Author
There was a problem hiding this comment.
Required for dockerImage object
yeslayla
force-pushed
the
hotfix/packageName
branch
from
0be2ad4 to
c414515
Compare
Contributor
Author
|
As a note, I tried removing the some of the |
dejonghe
suggested changes
Apr 7, 2025
dejonghe
left a comment
dejonghe
left a comment
There was a problem hiding this comment.
Trying to clear my open pr's, probably will never get implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setup.pyfile was updated to use the package namesemver-by-branch. The metadata was also updated to work with PyPi.The
Releasestage was split into theRelease Packagesstage andPush Docker Imagestage. TheRelease Packages Stagepushes packages to GitHub & PyPi while thePush Docker Imagestage pushes thelatesttag to DockerHub.README.mdThe
README.mdfile was updated to reflect installation using pip from PyPi.