Conversation
Collaborator
Author
Step. 1・MVCモデルを意識したフォルダ構成に変更する 参考 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
レビュー観点
package名は小文字かつ1単語で抑えられているかどうか
errorは,呼び出し元が処理されているまたは処理できるようerrorを返却しているかどうか
controller層で,ユーザのリクエストに適したモデルが呼び出されているかどうか
controller層は,モデルの値に対してユーザにレスポンスが返却されているかどうか
model層に,データの加工や処理などメインロジックが書かれているかどうか