Conversation
There was a problem hiding this comment.
Pull request overview
Este PR introduce una nueva landing (“Main 2.0”) para MAMB y amplía el frontend existente agregando una nueva pantalla de “IA Poses” basada en Teachable Machine (pose detection), junto con cambios orientados a PWA (manifest + intento de service worker).
Changes:
- Se agrega una landing completa (HTML + CSS) para la web pública de MAMB.
- Se incorpora una nueva pantalla “IA Poses” al frontend existente, con estilos dedicados y lógica de cámara/modelo en
Backend/app.js. - Se añade
manifest.jsony se inicia la integración de PWA (registro de SW), además de cargar TFJS/TeachableMachine desde CDN.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Landing MAMB/styles.css | Nuevo stylesheet para la landing (layout, responsive, animaciones). |
| Landing MAMB/landing.html | Nueva landing con navegación móvil, animaciones por IntersectionObserver y carrusel de servicios. |
| Frontend/style.css | Agrega estilos para la pantalla “IA Poses” (cámara, tarjetas de resultados, barras). |
| Frontend/index.html | Integra scripts de TFJS/TeachableMachine, añade pantalla IA y cambia rutas (CSS/JS), además de incluir manifest/SW. |
| Backend/manifest.json | Nuevo manifest PWA. |
| Backend/app.js | Añade módulo IA (carga de modelo, webcam, loop de predicción, UI de resultados). |
Comments suppressed due to low confidence (4)
Frontend/index.html:5
- Los <script> de TensorFlow/Teachable Machine están ubicados como hijos directos de (antes de ), lo que genera HTML inválido y puede afectar el orden de carga. Muévelos dentro de (idealmente con
defer) y aprovecha para usar rutas relativas consistentes para CSS/manifest.
Frontend/index.html:19 - El registro del Service Worker está entre y , y además apunta a
./sw.js, pero no existe ningúnsw.jsen el repo. Esto deja un error constante en consola en cada carga; o se añade el archivo, o se elimina el registro hasta tenerlo listo.
Frontend/index.html:772 /Backend/app.jses una ruta absoluta; si la app se sirve bajo un subpath (o se abre como archivo), el script no cargará. Usar una ruta relativa desdeFrontend/index.htmlevita roturas en despliegues y en desarrollo local.
Backend/app.js:586- El loop de IA sigue corriendo aunque el usuario navegue fuera de
screen-ia, dejando la cámara activa en segundo plano (implicación de privacidad/operación). Conviene detener el loop y cerrar los tracks de la webcam automáticamente al salir de esa pantalla.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+307
to
+309
| .art-p1 { background: #6B4C2A; } | ||
| .art-p2 { background: #4A3318; } | ||
|
|
Comment on lines
+340
to
+352
| const observer = new IntersectionObserver((entries) => { | ||
| entries.forEach(e => { | ||
| if (e.isIntersecting) { | ||
| e.target.classList.add('visible'); | ||
| const siblings = e.target.parentElement?.querySelectorAll('.fade-up'); | ||
| if (siblings) { | ||
| siblings.forEach((el, i) => { | ||
| setTimeout(() => el.classList.add('visible'), i * 120); | ||
| }); | ||
| } | ||
| } | ||
| }); | ||
| }, { threshold: 0.12 }); |
Comment on lines
+356
to
+365
| // Carousel | ||
| const track = document.querySelector('.services-track'); | ||
| const dots = document.querySelectorAll('.dot'); | ||
| const prevBtn = document.getElementById('prevBtn'); | ||
| const nextBtn = document.getElementById('nextBtn'); | ||
| const trackWrap = document.querySelector('.services-track-wrap'); | ||
| let current = 0; | ||
| const total = 4; | ||
| const gapPx = 16; // 1rem en píxeles | ||
|
|
Comment on lines
+171
to
+180
| <div class="carousel-controls"> | ||
| <button class="carousel-btn" id="prevBtn">←</button> | ||
| <div class="carousel-dots"> | ||
| <span class="dot active"></span> | ||
| <span class="dot"></span> | ||
| <span class="dot"></span> | ||
| <span class="dot"></span> | ||
| </div> | ||
| <button class="carousel-btn" id="nextBtn">→</button> | ||
| </div> |
Comment on lines
+318
to
+330
| const nav = document.getElementById('navbar'); | ||
| const hamburger = document.getElementById('hamburger'); | ||
| const mobileMenu = document.getElementById('mobileMenu'); | ||
|
|
||
| window.addEventListener('scroll', () => { | ||
| nav.classList.toggle('scrolled', window.scrollY > 40); | ||
| }); | ||
|
|
||
| hamburger.addEventListener('click', () => { | ||
| hamburger.classList.toggle('active'); | ||
| mobileMenu.classList.toggle('open'); | ||
| document.body.style.overflow = mobileMenu.classList.contains('open') ? 'hidden' : ''; | ||
| }); |
Comment on lines
+1
to
+20
| { | ||
| "name": "Mi App", | ||
| "short_name": "App", | ||
| "start_url": "./", | ||
| "display": "standalone", | ||
| "background_color": "#ffffff", | ||
| "theme_color": "#000000", | ||
| "icons": [ | ||
| { | ||
| "src": "./icon-192.png", | ||
| "sizes": "192x192", | ||
| "type": "image/png" | ||
| }, | ||
| { | ||
| "src": "./icon-512.png", | ||
| "sizes": "512x512", | ||
| "type": "image/png" | ||
| } | ||
| ] | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.