Use connections for embedded arrays#119
Open
Secretmapper wants to merge 1 commit intoRisingStack:masterfrom
Open
Use connections for embedded arrays#119Secretmapper wants to merge 1 commit intoRisingStack:masterfrom
Secretmapper wants to merge 1 commit intoRisingStack:masterfrom
Conversation
|
any updates on this PR? |
Contributor
|
@atalebagha I'll try to finish it, thanks for reminding me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117
Use Relay Connections for arrays of Sub-Documents.
This is a breaking change as it casts every array of subdocuments into relay style connections/edges. I figured this is okay as the relay connections can do everything graphqllists can do, but not vice-versa.
I'm not really sure if it is possible to cherry-pick or allow the addition of a sentinel value on the schema to prevent this, but I wasn't able to find any (since we're passing the Schema and not just the type object, it doesn't seem to allow the addition of arbitrary properties).
Again, let me know if you think it's all right and I'll add tests for them.