Converts sample rate and scale to floats when fetching memory depth.#7
Open
0ge wants to merge 1 commit intoRoGeorge:masterfrom
Open
Converts sample rate and scale to floats when fetching memory depth.#70ge wants to merge 1 commit intoRoGeorge:masterfrom
0ge wants to merge 1 commit intoRoGeorge:masterfrom
Conversation
Did not work when values were in scientific notation (could not add strings)
Author
|
It would be nice if this could either be merged or dismissed - I don't like loose ends. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample rate and scale can be returned in scientific notation from the scope, thus Python could not add strings and program crashed. This converts them explicitly to floats.