Resolve issues with no std#279
Merged
Kerollmops merged 2 commits intoRoaringBitmap:mainfrom May 30, 2024
Merged
Conversation
Contributor
|
LGTM; |
Kerollmops
requested changes
May 28, 2024
Member
Kerollmops
left a comment
There was a problem hiding this comment.
Thank you very much for the changes 🍦
However, to be sure that we don't break the code once again would it be possible to duplicate this part of the CI and change the parameters to run the tests (or at least compile) in no-std, please?
Contributor
|
Just add this part: - name: Test
uses: actions-rs/cargo@v1
with:
command: test
args: --no-default-featuresor - name: Test
uses: actions-rs/cargo@v1
with:
command: build
args: --no-default-features |
Member
|
I would say let's try with the test one, but if it doesn't pass, we can only try to build it. |
Contributor
Author
|
Thanks, I'll try this now and see how it goes. |
Contributor
|
It seems that all the checks passed as expected. |
Kerollmops
approved these changes
May 30, 2024
Member
Kerollmops
left a comment
There was a problem hiding this comment.
Thank you very much, folks 👌 I am merging this. I will do a release once #280 is merged too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve #278 and resolve #273 and also satisfy the clippy lints via cfg flags.