Refactor LibraryContent: remove TaxonomySidebar, integrate into ElementBrowser#118
Merged
Refactor LibraryContent: remove TaxonomySidebar, integrate into ElementBrowser#118
Conversation
…omy selection into ElementBrowser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
LibraryContentcomponent by removing the standaloneTaxonomySidebarcomponent and integrating taxonomy selection directly into theElementBrowser. This simplifies the library view layout and consolidates taxonomy-related UI into a single component.Changes
TaxonomySidebarimport and usage fromLibraryContent, eliminating a separate sidebar panel for taxonomy filtering.taxonomyIdandsetTaxonomyIdas props toElementBrowser, moving taxonomy selection responsibility into the browser component itself.ElementBrowsercomponent that handles taxonomy selection internally.selectedTaxonomystate variable that was previously used to bridge communication betweenTaxonomySidebarand the rest of the component (replaced by directtaxonomyId/setTaxonomyIdprop drilling intoElementBrowser).Key UI/UX Improvements
ElementBrowser, reducing visual clutter and providing a more cohesive browsing experience.Breaking Changes
ElementBrowsercomponent contract has changed: It now expectstaxonomyIdandsetTaxonomyIdprops. Any other consumers ofElementBrowserwill need to be updated accordingly.TaxonomySidebarmay now be unused — verify if it can be deprecated/removed from the codebase entirely.Testing Notes
ElementBrowsercomponent.ElementBrowserprop signature without the new taxonomy props.Browser Compatibility Considerations
🤖 Generated with Claude Code
Branch Info:
chore/update-library-viewmainCo-Authored-By: Claude noreply@anthropic.com