Skip to content

Update event block and taxonomy block models with new attributes#104

Merged
jfrench9 merged 1 commit intomainfrom
feature/update-event-block
Apr 25, 2026
Merged

Update event block and taxonomy block models with new attributes#104
jfrench9 merged 1 commit intomainfrom
feature/update-event-block

Conversation

@jfrench9
Copy link
Copy Markdown
Member

Summary

This PR extends the event block and taxonomy block request models with new attributes, introduces a new CreateEventBlockRequestEventClass enum model, and improves the ledger client with additional convenience methods. Documentation across affected models has also been improved.

Key Accomplishments

New Model & Exports

  • Added new CreateEventBlockRequestEventClass enum model to support event classification
  • Registered the new model in models/__init__.py for proper module exports

Event Block Model Enhancements

  • CreateEventBlockRequest: Significantly expanded with new attributes (~75 lines of additions), enriching the data that can be provided when creating event blocks
  • UpdateEventBlockRequest: Extended with additional fields (~50 lines of additions) to bring update capabilities in line with the expanded creation model
  • CreateEventBlockRequestEventCategory: Added new event category options

Taxonomy Block & Element Model Refinements

  • TaxonomyBlockElementRequest: Refactored field definitions (field reordering/renaming across ~24 lines changed)
  • UpdateTaxonomyBlockRequest: Minor attribute adjustments
  • ElementUpdatePatch: Refactored field definitions for consistency

Ledger Client Improvements

  • Extended ledger_client.py with ~40 lines of new client methods or method enhancements, providing richer API interaction capabilities for event and taxonomy blocks

API Operation Updates

  • op_evaluate_rules.py: Adjusted request model usage to align with updated EvaluateRulesRequest
  • op_update_taxonomy_block.py: Updated to work with revised taxonomy block models

Breaking Changes

⚠️ Potential breaking changes:

  • Field renaming/restructuring in ElementUpdatePatch and TaxonomyBlockElementRequest may break existing consumers relying on previous field names or ordering
  • Changes to EvaluateRulesRequest fields may affect existing rule evaluation callers
  • Updated UpdateTaxonomyBlockRequest attributes may require callers to adjust payloads

Consumers of these models should review their usage and update accordingly.

Testing Notes

  • Verify that event block creation and update workflows function correctly with the newly added attributes
  • Validate that the new CreateEventBlockRequestEventClass enum values are accepted by the API
  • Test taxonomy block update operations to confirm compatibility with refactored element request models
  • Ensure rule evaluation flows still work correctly with the updated EvaluateRulesRequest model
  • Confirm ledger client new methods integrate properly with the backend API

Infrastructure Considerations

  • No new dependencies introduced
  • Model changes are client-side and should be validated against the corresponding API schema version to ensure compatibility
  • Downstream services consuming these models may need coordinated updates if they depend on the modified field structures

🤖 Generated with Claude Code

Branch Info:

  • Source: feature/update-event-block
  • Target: main
  • Type: feature

Co-Authored-By: Claude noreply@anthropic.com

@jfrench9 jfrench9 merged commit fc6060f into main Apr 25, 2026
1 check passed
@jfrench9 jfrench9 deleted the feature/update-event-block branch April 25, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant