Skip to content

Refactor: Replace 'classification' with 'trait' in GraphQL queries#105

Merged
jfrench9 merged 1 commit intomainfrom
chore/fix-graqhql-queries
Apr 25, 2026
Merged

Refactor: Replace 'classification' with 'trait' in GraphQL queries#105
jfrench9 merged 1 commit intomainfrom
chore/fix-graqhql-queries

Conversation

@jfrench9
Copy link
Copy Markdown
Member

Summary

This PR updates GraphQL queries in the robosystems_client package to replace references to classification with trait, aligning the client queries with an updated GraphQL schema/API.

Key Accomplishments

  • Ledger queries updated: Replaced all occurrences of classification with trait across ledger-related GraphQL query definitions (11 line changes), ensuring the client correctly queries the current API schema.
  • Library queries updated: Similarly updated library-related GraphQL query definitions (6 line changes) to use trait instead of classification.
  • Consistent terminology: Both query modules now use the unified trait terminology, maintaining consistency across the entire client query layer.

Breaking Changes

⚠️ Yes — this is a breaking change if consumers depend on the previous field names.

  • Any downstream code that references classification fields in GraphQL response objects will need to be updated to use trait instead.
  • This change assumes the backend GraphQL schema has already been updated (or is being updated in tandem) to expose trait rather than classification. If the backend still serves classification, these queries will fail.

Testing Notes

  • Verify that all GraphQL queries in both ledger and library modules execute successfully against the target API environment.
  • Confirm that response parsing and any dependent business logic correctly handle the renamed trait field.
  • Run integration tests to ensure end-to-end flows (ledger lookups, library queries) return expected results with the updated field name.
  • Check for any other references to classification elsewhere in the codebase that may also need updating for consistency.

Infrastructure Considerations

  • Ensure the GraphQL API/schema that this client communicates with has been deployed with the trait field available before rolling out this client change to production.
  • Coordinate deployment ordering: backend schema changes should be live before clients using this updated query set are deployed, to avoid query resolution errors.
  • Consider backward compatibility if multiple client versions may be active simultaneously during rollout.

🤖 Generated with Claude Code

Branch Info:

  • Source: chore/fix-graqhql-queries
  • Target: main
  • Type: feature

Co-Authored-By: Claude noreply@anthropic.com

@jfrench9 jfrench9 merged commit df26090 into main Apr 25, 2026
1 check passed
@jfrench9 jfrench9 deleted the chore/fix-graqhql-queries branch April 25, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant