Skip to content

fix link error on build of rosidl_generator_py on macOS #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrxder wants to merge 2 commits into from
Closed

fix link error on build of rosidl_generator_py on macOS #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00bfa52
fix(rosidl_generator_py): link Python3 PRIVATE on macOS to resolve un…
mrxder Jun 11, 2026
424457e
fix: link Python3::Module on macOS for rosidl_generator_py
mrxder Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions patch/ros-jazzy-rosidl-generator-py.osx.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ index cfc424a..cddd23d 100644
endif()

+if(APPLE)
+ set_target_properties(${_target_name_lib} PROPERTIES LINK_FLAGS "-undefined dynamic_lookup")
+ target_include_directories(${_target_name_lib} PUBLIC ${Python3_INCLUDE_DIRS} ${Python3_NumPy_INCLUDE_DIRS})
+ target_link_libraries(${_target_name_lib} PRIVATE Python3::NumPy Python3::Module)
+ target_include_directories(${_target_name_lib} PRIVATE ${Python3_INCLUDE_DIRS} ${Python3_NumPy_INCLUDE_DIRS})
+else()
+ target_link_libraries(${_target_name_lib} PUBLIC Python3::NumPy Python3::Python)
+endif()
Expand Down Expand Up @@ -66,4 +66,4 @@ index cfc424a..cddd23d 100644
+ target_link_libraries(${_target_name_lib} PUBLIC ${${_pkg_name}_TARGETS${rosidl_generator_py_suffix}})
endforeach()

set_target_properties(${_target_name_lib} PROPERTIES COMPILE_OPTIONS "${_extension_compile_flags}")
set_target_properties(${_target_name_lib} PROPERTIES COMPILE_OPTIONS "${_extension_compile_flags}")
Loading